Get rid of Python dependencies now that pywb is gone #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review |
|
Hum, looks like Python is still used for cdxj indexer ... so this will have to be fixed indeed. Not ready for review then, sorry. |
|
Closing this in favor of #591 |
Yes at this point it's still used to create WACZ files. That should change soon with a switch to js-wacz however :) Thanks for the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I've understood, pywb is not used anymore now.
We however still have few Python dependencies which AFAIK are not used by the crawler anymore. I propose to get rid of them since this will make life easier to migrate to Ubuntu Noble